Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update contracts folder structure #420

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Fix: update contracts folder structure #420

wants to merge 18 commits into from

Conversation

VGau
Copy link
Collaborator

@VGau VGau commented Dec 10, 2024

This PR implements issue(s) #399

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@VGau VGau requested a review from a team as a code owner December 10, 2024 15:37
@VGau VGau had a problem deploying to docker-build-and-e2e December 10, 2024 15:38 — with GitHub Actions Error
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.45%. Comparing base (6daac29) to head (3ad0955).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../src/verifiers/PlonkVerifierForDataAggregation.sol 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #420      +/-   ##
============================================
+ Coverage     68.20%   70.45%   +2.24%     
+ Complexity     1128     1061      -67     
============================================
  Files           319      302      -17     
  Lines         12846    12209     -637     
  Branches       1291     1175     -116     
============================================
- Hits           8762     8602     -160     
+ Misses         3553     3136     -417     
+ Partials        531      471      -60
Flag Coverage Δ *Carryforward flag
hardhat 99.04% <85.71%> (+0.40%) ⬆️
kotlin 68.05% <ø> (+2.29%) ⬆️ Carriedforward from 3f43947

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
contracts/src/bridging/token/BridgedToken.sol 100.00% <ø> (ø)
contracts/src/bridging/token/TokenBridge.sol 100.00% <ø> (ø)
contracts/src/governance/TimeLock.sol 100.00% <ø> (ø)
...ntracts/src/libraries/EfficientLeftRightKeccak.sol 100.00% <ø> (ø)
contracts/src/libraries/Mimc.sol 100.00% <ø> (ø)
contracts/src/libraries/SparseMerkleProof.sol 100.00% <ø> (ø)
...ontracts/src/libraries/TransientStorageHelpers.sol 100.00% <ø> (ø)
contracts/src/messaging/MessageServiceBase.sol 100.00% <ø> (ø)
contracts/src/messaging/l1/L1MessageManager.sol 100.00% <100.00%> (ø)
contracts/src/messaging/l1/L1MessageService.sol 100.00% <ø> (ø)
... and 21 more

... and 52 files with indirect coverage changes

alainncls
alainncls previously approved these changes Dec 10, 2024
View reviewed changes
kyzooghost
kyzooghost reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@kyzooghost kyzooghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest that we also update the autogenerated documentation in contracts/docs/api?

@VGau VGau had a problem deploying to docker-build-and-e2e December 11, 2024 08:46 — with GitHub Actions Error
@VGau VGau temporarily deployed to docker-build-and-e2e December 11, 2024 10:15 — with GitHub Actions Inactive
kyzooghost
kyzooghost previously approved these changes Dec 11, 2024
View reviewed changes
@VGau VGau had a problem deploying to docker-build-and-e2e December 20, 2024 12:19 — with GitHub Actions Error
@VGau VGau temporarily deployed to docker-build-and-e2e December 20, 2024 12:25 — with GitHub Actions Inactive
@VGau VGau temporarily deployed to docker-build-and-e2e January 6, 2025 09:54 — with GitHub Actions Inactive
@VGau VGau had a problem deploying to docker-build-and-e2e January 6, 2025 14:25 — with GitHub Actions Error
@VGau VGau had a problem deploying to docker-build-and-e2e January 6, 2025 15:13 — with GitHub Actions Error
@VGau VGau had a problem deploying to docker-build-and-e2e January 6, 2025 15:42 — with GitHub Actions Error
@VGau VGau had a problem deploying to docker-build-and-e2e January 6, 2025 15:54 — with GitHub Actions Error
@VGau VGau had a problem deploying to docker-build-and-e2e January 7, 2025 09:54 — with GitHub Actions Error
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Jan 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@VGau VGau had a problem deploying to docker-build-and-e2e January 7, 2025 11:53 — with GitHub Actions Error
@VGau VGau temporarily deployed to docker-build-and-e2e January 7, 2025 12:38 — with GitHub Actions Inactive
@VGau VGau had a problem deploying to docker-build-and-e2e January 7, 2025 15:41 — with GitHub Actions Error
@VGau VGau temporarily deployed to docker-build-and-e2e January 7, 2025 15:59 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyzooghost kyzooghost kyzooghost left review comments

@alainncls alainncls alainncls left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VGau @codecov-commenter @alainncls @kyzooghost